Skip to content

fix: move ProgressBar and ModelCheckpoint callbacks to the end in reorder_callbacks #21268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: move ProgressBar and ModelCheckpoint callbacks to the end in reorder_callbacks #21268

wants to merge 3 commits into from
+22 −16

Conversation

deependujha
Copy link
Collaborator

@deependujha deependujha commented Oct 6, 2025 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #21264

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21268.org.readthedocs.build/en/21268/

@deependujha
Reorder callback list to prioritize tuner-specific callbacks and main…
d1a2c3a 
…tain order for ProgressBar and ModelCheckpoint
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025 •
edited
Loading

🌩️ Required checks status: Pending 🟡

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success ✅

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py, tests/tests_pytorch/callbacks/test_callbacks.py, tests/tests_pytorch/trainer/connectors/test_callback_connector.py.

🟡 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-runtime-ubuntu22.04, pytorch, 3.10) no_status ❓
pytorch.yml / Lit Job (lightning, 3.12) no_status ❓
pytorch.yml / Lit Job (pytorch, 3.12) no_status ❓

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py, tests/tests_pytorch/callbacks/test_callbacks.py, tests/tests_pytorch/trainer/connectors/test_callback_connector.py.

🟡 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) no_status ❓
benchmark.yml / Lit Job (pytorch) no_status ❓

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 install
Check ID Status
install-pkg-guardian success ✅

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 70 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov Codecov
Copy link

codecov bot commented Oct 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (4dc1dbc) to head (fa5164c).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (4dc1dbc) and HEAD (fa5164c). Click for more details.

HEAD has 360 uploads less than BASE
Flag BASE (4dc1dbc) HEAD (fa5164c)
cpu 108 27
python 12 3
lightning_fabric 26 0
pytest 57 0
python3.12 12 3
python3.12.7 36 9
lightning 61 15
python3.11 24 6
python3.10 24 6
gpu 3 0
pytorch2.1 12 6
pytest-full 54 27
pytorch2.8 6 3
pytorch_lightning 24 12
pytorch2.4.1 6 3
pytorch2.3 6 3
pytorch2.2.2 6 3
pytorch2.7 6 3
pytorch2.5.1 6 3
pytorch2.6 6 3
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #21268     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         269      266      -3     
  Lines       23690    23638     -52     
=========================================
- Hits        20671    18641   -2030     
- Misses       3019     4997   +1978

SkafteNicki
SkafteNicki requested changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until discussion in #21264 is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki requested changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TQDMProgressBar bug (?) causes DDP to hang
2 participants
@deependujha @SkafteNicki